Skip to content

Conversation

@LarsKue
Copy link
Contributor

@LarsKue LarsKue commented Apr 7, 2025

Fixes #298

@LarsKue LarsKue requested a review from stefanradev93 April 7, 2025 23:18
@LarsKue LarsKue self-assigned this Apr 7, 2025
@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
bayesflow/experimental/cif/conditional_gaussian.py 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
bayesflow/networks/mlp/mlp.py 100.00% <ø> (+3.03%) ⬆️
bayesflow/experimental/cif/conditional_gaussian.py 30.95% <0.00%> (ø)

... and 6 files with indirect coverage changes

@LarsKue LarsKue requested a review from Copilot April 8, 2025 17:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

bayesflow/networks/mlp/mlp.py:48

  • [nitpick] Consider revising the docstring for 'widths' to remove any remnants of the 'depth' and 'width' parameters and explicitly state that the length of the 'widths' list defines the number of layers.
Defines the number of hidden units per layer, as well as the number of layers to be used.

@LarsKue LarsKue merged commit e0f8b4e into dev Apr 8, 2025
14 of 15 checks passed
@LarsKue LarsKue deleted the remove-width-and-depth-args-in-mlp branch April 8, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants