Conversation
- Add MaterialToolbar to activity_preferences layout and wire it up in EditPreferencesActivity with a back-navigation handler, fixing the pre-existing missing action bar in the Settings screen. - Standardise share/play/favourite ImageViews to 48dp touch targets with 12dp padding (Material Design system defaults), replacing the previous 40dp/8dp values. - Expand the play-arrow vector path so it fills its 24dp viewport as well as the share and star icons do, removing the visual size mismatch. - Upgrade Gradle wrapper and AGP/Kotlin plugin versions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MaterialToolbarto the preferences screen layout and wired it up inEditPreferencesActivitywithsetSupportActionBar+ a back-navigation handler — fixing the pre-existing missing action bar.ImageViews on definition cards to 48dp touch targets with 12dp padding, matching Material Design system defaults (previously 40dp/8dp).M8 5v14l11-7ztoM5 3l15 9-15 9V3zso it visually fills its viewport as well as the share and star icons do, removing the apparent size mismatch between the three icons.Test plan
🤖 Generated with Claude Code