Merged
Conversation
Collaborator
|
Could you use the special characters for the ellipsis please. |
Contributor
Author
|
Sir yes sir 🫡 |
Collaborator
|
Thanks for the pr!! Looks good, except for "No background tasks! -> "All your apps are up to date!": these do not mean the same thing. There can still be available updates when this label is active |
Contributor
Author
|
mmh I did not know that |
Contributor
Author
|
That's quite the commit so here's a list of stuff you might want to review :
(here's how it looks in the "Manage user data" page, I forgot to change the layout there, if you want to compare 😅)
If there's a change that's not okay, we can go back no problem |
Collaborator
|
Looks good! |
Collaborator
|
Thanks! Have a great day! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Hi !
There are some strings that seemed weird to me or not accessible enough.
So I've tried to fix that ^^"
It's not finished, and I'm also going to fix #922 while I'm at it.
It shouldn't be included for 0.7.9 but 0.7.10 instead, so we don't need to delay it and redo the translations.
Feel free to give feedback on the changes !