fix: the macro defined in bge/util in util.h#1475
Closed
orbisai0security wants to merge 1 commit into
Closed
Conversation
Automated security fix generated by Orbis Security AI
orbisai0security
requested review from
AlexanderVanhee and
kolunmi
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
bge/util.h.Vulnerability
V-002bge/util.h:78Description: The macro defined in bge/util.h at line 78 calls g_free(self) without subsequently setting self to NULL. This pattern is replicated across bge-animation.c (lines 808 and 817, where the same ptr variable appears to be freed twice) and bge-wdgt-spec.c (lines 1028 and 4203). When a freed pointer is not nullified, any subsequent dereference of that pointer — through a retained reference in a widget structure, animation state, or callback — constitutes a use-after-free. The double-free pattern in bge-animation.c (ptr freed at both line 808 and 817) is particularly concerning as it can corrupt heap allocator metadata directly.
Changes
bge/util.hVerification
Automated security fix by OrbisAI Security