Fix transaction level error reporting#1485
Merged
kolunmi merged 1 commit intoMay 13, 2026
Merged
Conversation
Most errors are specific to a job, but there are also transaction level errors, most easily seen when not entering a password in a polkit prompt. These were seemingly ignored before, as they were returned as an error hashmap. Now this hashmap gets properly read and set as an error, and the transaction gets also marked as cancelled. This fixes the issue where the bundle install dialog reports the app as installed when the user did not provide their password, even though the installation did not actually complete.
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most errors are specific to a job, but there are also transaction level errors, most easily seen when not entering a password in a polkit prompt. These were seemingly ignored before, as they were returned as an error hashmap. Now this hashmap gets properly read and set as an error, and the transaction gets also marked as cancelled.
This fixes the issue where the bundle install dialog reports the app as installed when the user did not provide their password, even though the installation did not actually complete.