Improve screenshot carousel to show more screenshots#916
Merged
kolunmi merged 3 commits intobazaar-org:mainfrom Jan 5, 2026
Merged
Improve screenshot carousel to show more screenshots#916kolunmi merged 3 commits intobazaar-org:mainfrom
kolunmi merged 3 commits intobazaar-org:mainfrom
Conversation
Collaborator
|
hmm, it seems the carousel doesn't follow focus? |
Collaborator
Author
|
The Adw.Carousel also does not seem to follow focus. |
Collaborator
|
hmmm k |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes an in tree copy of the carousel so we can improve it for our purposes. The current change removes the homogeneous spacing between the center of each widget, which previously caused screenshot carousels with different aspect ratio images to have massive gaps between screenshots.
To further show more screenshots, I changed the carousel so it starts from the second position when the user enters an app page on a wide window, avoiding a large empty space on the left side of the window. In that scenario, I also switched the first and second screenshots to make sure the best screenshot starts in the center.
I had to also fork the indicator dots as an Adw.Carousel cant be inherited from.