refactor: Minor compatibility fixes #1044
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the Bazel documentation, this option has already been deprecated for quite a long time. It already defaults to True.
Ever since Bazel 7.2, the officially documented method for accessing the host constraints is to load @platforms//host:constraints.bzl. More details: https://bazel.build/extending/platforms#specifying-build-platform https://bazel.build/concepts/platforms#default-platforms
Ever since bzlmod, @// has lost any official meaning: https://bazel.build/concepts/labels Bazel still seems to allow it, but given the fact that this format is no longer documented we should stop using it. In this specific case it also doesn't matter. As long as we provide a label that is valid.
EdSchouten
changed the title
Contributor
Author
|
Friendly ping! |
Collaborator
|
Hm, we still support Bazel 6 in bazel-lib 2.x, and CI failure there is Maybe we still need |
Collaborator
|
@EdSchouten we're playing with https://github.com/google/triage-party today. It says I should ask you to merge - even though I should probably do the work myself :) |
Collaborator
|
Alternatively I'm considering a 3.0 of bazel-lib (including the module rename from aspect_bazel_lib) so maybe we drop Bazel 6 support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am writing an experimental analysis tool that is capable of parsing BUILD/.bzl files. In the process I ran into some minor issues processing some of the code in bazel-lib. In many cases I obviously fixed up my tool, but I was left with some breakages where I think it makes sense to alter bazel-lib instead, because the Bazel documentation indicates that the feature at hand is deprecated. Merging such changes prevent potential breakages in the future.