Add additional argument to write_source_file macro: out_file_is_select = False, that enables support for defining select dictionary as out_file.
#782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional argument to write_source_file macro: `out_file_is_select = False`, that enables support for defining select dictionary as out_file. For example:
`
write_source_file(
name = "write_foo_c",
in_file = ":foo.c",
out_file = {
"//conditions:default": "//workspace/subdir:foo.c",
},
executable = False,
additional_update_targets = [],
suggested_update_target = ":write_foo_h",
diff_test = True,
check_that_out_file_exists = False,
out_file_is_select = True,
)
`
Add support for select in write_source_file.bzl
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This change is not tested in all cases. It serves as sample implementation for:
FR: write_source_files and write_source_file shall support select() #781
Type of change
New feature or functionality (change which adds functionality)
Relevant documentation has been updated
Suggested release notes are provided below:
Test plan