Skip to content

Fix pmd_test to use short_path instead of path for sources #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2025
Merged

Fix pmd_test to use short_path instead of path for sources #390

merged 1 commit into from
Nov 19, 2025
+1 −1

Conversation

@styurin
Copy link
Contributor

@styurin styurin commented Nov 13, 2025

From https://bazel.build/rules/lib/builtins/File#path:

Use the short_path for the path under which the file is mapped if it's in the runfiles of a binary.

Fixes an issue with pmd_test not finding sources produced by other targets.

@styurin styurin marked this pull request as ready for review November 13, 2025 05:06
shs96c
shs96c approved these changes Nov 19, 2025
View reviewed changes
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@shs96c shs96c merged commit fa1c184 into bazel-contrib:main Nov 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shs96c shs96c shs96c approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@styurin @shs96c