tests: expose fcgi and genhtml to bzlmod #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This 2 repos where not exposed in bzlmod
lalten
reviewed
Feb 21, 2025
lalten
reviewed
Feb 21, 2025
Make sure make variables get properly expanded in env flags similar to how other rules work
This test uses the extension in non dev mode to show we can build a very basic target
Fixing violations that we're getting in CI
perl_xs is failing to link in non linux right now
Contributor
Author
|
@lalten any chance you can review again? |
Contributor
I'm not a maintainer of rules_perl :) |
Contributor
Author
|
@skeletonkey any chance you can review? |
Collaborator
|
@manuelnaranjo Looks good. There are two unresolved discussions; please review and resolve those, and I will merge the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This 2 repos where not exposed in bzlmod, had to fix buildifier CI and added an e2e test that consumes the rules with bzlmod without dev_dependency = True to validate the rule public API is not regressing