Added runfiles implementation #92
Merged
+510
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
If this change is merged then a new release should be cut. |
skeletonkey
reviewed
Oct 31, 2025
perl/runfiles/Runfiles.pm
Outdated
| =cut | ||
|
|
||
| sub create { | ||
| my ($class) = @_; |
Collaborator
There was a problem hiding this comment.
This may not apply here, but do you want to guard against 'create' being called on a blessed instance with:
my $package = shift;
my $class = ref($package) || $package;
Contributor
Author
There was a problem hiding this comment.
What do you mean "blessed instance"? I'm happy to apply any changes though.
Collaborator
There was a problem hiding this comment.
I've seen this happen before:
my $r = Runfiles->create();
my $r2 = $r->create(); // current implementation wouldn't support this bad use case
skeletonkey
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #85