-
-
Notifications
You must be signed in to change notification settings - Fork 674
Open
Description
🐞 bug report
Affected Rule
The issue is caused by the rule: py_zipapp_binary
Is this a regression?
No, this is a new ruleDescription
A clear and concise description of the problem...You're supposed to be able to specify compression per
rules_python/python/private/zipapp/py_zipapp_rule.bzl
Lines 250 to 257 in bac5494
| "compression": attr.string( | |
| doc = """ | |
| The compression level to use. | |
| Typically 0 to 9, with higher numbers being to compress more. | |
| """, | |
| default = "", | |
| ), |
"9".
🔬 Minimal Reproduction
Create any py_zipapp_binary and try to specify compression
🔥 Exception or Error
This makes the call unhappy and you get an error like this.
```
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
usage: zipper_.py [-h] [--compression COMPRESSION]
[--workspace-name WORKSPACE_NAME]
[--legacy-external-runfiles {0,1}]
[--runfiles-dir RUNFILES_DIR]
manifest output
zipper_.py: error: argument --compression: invalid int value: '%s'
```
🌍 Your Environment
Operating System:
Linux
Output of bazel version:
8.4.2
Rules_python version:
1.9.0
Anything else relevant?
It looks like a simple format = is missing in the line that is supposed to support compression setting.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels