fix: Mark internal config repo as reproducible for Bzlmod

[aaronsky]

When I updated past 1.6.3, I noticed that my MODULE.bazel.lock was being updated with locking details of the internal dependencies of rules_python. My understanding is that http_archive and non-watched repository files tend to be easy to mark reproducible, which avoids unnecessary updates to the lockfile. I have verified this on an internal project that this does what I expect it to.

[gemini-code-assist]

Summary of Changes

Hello @aaronsky, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the MODULE.bazel.lock file was being updated unnecessarily due to internal dependencies of rules_python when using Bzlmod. By conditionally marking the internal configuration repository as reproducible, the change aims to stabilize the lockfile, reducing churn and improving the overall developer experience for projects leveraging Bzlmod with rules_python.

Highlights

• Reproducibility for Bzlmod: The internal configuration repository is now conditionally marked as reproducible for Bzlmod, preventing unnecessary updates to the MODULE.bazel.lock file.
• Bazel Feature Detection: Introduced bazel_features to dynamically check for Bazel version capabilities, specifically for the reproducible flag in extension_metadata.
• Code Readability: The parameter name mctx in the _config_impl function has been renamed to module_ctx for improved clarity and consistency with Bazel's module extension context.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly marks the internal configuration repository as reproducible for Bzlmod. This is a valuable fix that will prevent unnecessary updates to the MODULE.bazel.lock file for users of rules_python. The implementation properly uses bazel_features to conditionally set the reproducible flag, ensuring backward compatibility with older Bazel versions. Additionally, renaming mctx to module_ctx improves code clarity and aligns with standard Bazel conventions. The changes are well-executed and address the issue effectively.

[rickeylev]

Thanks for the fix!