Skip to content

Comments

fix: Return repo_metadata from python repository rule#3598

Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom
mortenmj:mmj/python-reproducible
Feb 15, 2026
Merged

fix: Return repo_metadata from python repository rule#3598
rickeylev merged 1 commit intobazel-contrib:mainfrom
mortenmj:mmj/python-reproducible

Conversation

@mortenmj
Copy link
Contributor

This allows the python repository rule to use the remote repo content cache.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mortenmj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the python_repository rule by integrating Bazel's repo_metadata feature. This change allows the rule to interact with the remote repository content cache, which significantly benefits build efficiency and consistency for Python dependencies. The implementation carefully handles different Bazel versions to ensure broad compatibility.

Highlights

  • Remote Cache Compatibility: The python_repository rule was updated to return repo_metadata, enabling it to utilize the remote repository content cache for improved build performance and reproducibility.
  • Bazel Version Compatibility: A check was added to conditionally return repo_metadata only if the Bazel version supports it (Bazel >= 8.3.0), ensuring backward compatibility with older Bazel environments.
  • Reproducibility Flag: The reproducible flag for repo_metadata is now set based on whether a sha256 attribute is provided, accurately reflecting the reproducibility status of the repository.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • python/private/python_repository.bzl
    • Modified the _python_repository_impl function to conditionally return repo_metadata based on Bazel version support.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to enable remote caching for the python_repository rule by returning repo_metadata. However, the implementation for reproducible repositories is incorrect and will lead to incorrect remote cache hits. I've left a comment with a critical fix.

rickeylev
rickeylev previously approved these changes Feb 14, 2026
@rickeylev rickeylev added this pull request to the merge queue Feb 14, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 14, 2026
@rickeylev rickeylev added this pull request to the merge queue Feb 14, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 14, 2026
@rickeylev rickeylev added this pull request to the merge queue Feb 14, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 14, 2026
@rickeylev rickeylev added this pull request to the merge queue Feb 15, 2026
Merged via the queue into bazel-contrib:main with commit 22f1352 Feb 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants