fix(pypi): handle unnormalized package names when extracting sdist version

[aignas]

With this change we are handling more of the edge cases for when the
filenames are more complex. Initial code had bugs when the sdist name
had - in the name part.

This code is easier to read and a little bit more explicit how it
handles things.

We will use it later to only return the whl and sdist entries for
the versions requested through the requirements lock file. This is to
make it possible to write facts only for the versions that we use.

Work towards #2731

[gemini-code-assist]

Summary of Changes

Hello @aignas, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors and enhances the logic for extracting package versions from PyPI distribution filenames. It centralizes the version parsing into a new, more robust utility, which now correctly handles complex sdist names that previously caused issues. This improvement is crucial for accurately identifying package versions and will facilitate future work on filtering package entries based on requirements.

Highlights

• Improved Version Extraction: The logic for extracting package versions from PyPI distribution filenames has been significantly improved, specifically addressing edge cases where sdist names contained hyphens or were unnormalized.
• Refactored Parsing Logic: Version parsing has been refactored into a dedicated version_from_filename.bzl module, enhancing readability, maintainability, and reusability of the code.
• Comprehensive Testing: New unit tests have been introduced for the version_from_filename utility, covering various wheel and sdist naming conventions, including complex and failure scenarios, to ensure robustness.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• python/private/pypi/BUILD.bazel
  • Updated parse_simpleapi_html_bzl to depend on the new version_from_filename_bzl.
• python/private/pypi/parse_simpleapi_html.bzl
  • Refactored version extraction by importing and utilizing the new version_from_filename function.
  • Removed the old _version helper function.
• python/private/pypi/version_from_filename.bzl
  • Added a new module containing a robust version_from_filename function to parse versions from wheel and sdist filenames, handling various naming conventions.
• tests/pypi/version_from_filename/BUILD.bazel
  • Added a new BUILD file to define the test suite for the version_from_filename utility.
• tests/pypi/version_from_filename/version_from_filename_tests.bzl
  • Added comprehensive unit tests for the version_from_filename function, covering standard and complex wheel and sdist naming scenarios.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the version parsing logic from filenames into a dedicated file, which improves modularity. The new logic for sdist filenames is more robust and handles package names with hyphens correctly. However, the logic for parsing wheel filenames is still susceptible to errors when package names contain hyphens. I've left a specific comment on this. The addition of tests for the new function is great.