Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds 'Design' and 'Common misconceptions' sections to the README.md, providing details on platform support, dependency management, and performance scaling. The review feedback highlights several style and correctness issues, including lines exceeding the 100-character limit, grammatical errors, an incorrect PEP reference, and inconsistent capitalization of 'Bazel'.
| * The `py_binary`, `py_test` rules should scale to large monorepos and we work hard to minimize the work done during analysis and build phase. What is more, the space requirements for should be minimal, so we strive to use symlinks rather than extracting wheels at build time. This means that for different configurations of the same build, we are not extracting the wheel multiple times thus scaling better over the time. From `2.0` onwards we are creating a virtual env for each target by creating an actual minimal virtual environment using symlinks. We plan on creating the traditional `site-packages` layout in the future by default. | ||
| * Support for standards - we strive to first implement any standards needed within `rules_python` and this has resulted in a few PEPs supported within pure starlark - PEP440, PEP509. |
There was a problem hiding this comment.
These lines exceed the 100-character limit. Additionally, line 26 contains grammatical errors ('space requirements for should be' and 'over the time'), and line 27 likely refers to PEP 508 (Dependency specification) rather than PEP 509 (Dictionary versioning).
References
- Max line length: 100. (link)
rickeylev
left a comment
rickeylev
left a comment
There was a problem hiding this comment.
I did some heavy copy editing and rewrite. LGTM on the main topics, though.
2 participants
Just to start a page on design notes to tell users better what they are getting.