refactor(twine): use py_binary for publishing in WORKSPACE#3734
Open
aignas wants to merge 4 commits intobazel-contrib:mainfrom
Open
refactor(twine): use py_binary for publishing in WORKSPACE#3734aignas wants to merge 4 commits intobazel-contrib:mainfrom
aignas wants to merge 4 commits intobazel-contrib:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the py_wheel rule in python/packaging.bzl to use py_console_script_binary instead of py_binary for the twine publishing target. This change simplifies the implementation by removing the need for manual entry point script generation. Feedback suggests removing the imports = ["."] attribute from the new rule call to prevent potential name collisions and redundant path configurations.
aignas
commented
Apr 24, 2026
rickeylev
approved these changes
Apr 25, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
Since py_binary supports main_module now and I think twine also supports python -m twine, what is the reason to not just use py_binary(main_module=...)? |
aignas
changed the title
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the reliance on defunct entry point code.
Work towards #3642.