fix(pypi): include RECORD file in installed wheel targets#3752
Open
rickeylev wants to merge 1 commit intobazel-contrib:mainfrom
Open
fix(pypi): include RECORD file in installed wheel targets#3752rickeylev wants to merge 1 commit intobazel-contrib:mainfrom
rickeylev wants to merge 1 commit intobazel-contrib:mainfrom
Conversation
Currently, `importlib.metadata.files()` returns `None` for packages installed via `rules_python`'s wheel rules. This happens because the `RECORD` file in the `.dist-info` directory is explicitly excluded from the `data` attribute of the generated `py_library` targets. To fix this, remove `**/*.dist-info/RECORD` from the `_data_exclude` list in `whl_library_targets.bzl`. This ensures that the `RECORD` file is preserved in the runfiles and available at runtime, enabling `importlib.metadata.files()` to correctly list the files in the package.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies whl_library_targets.bzl to stop excluding **/*.dist-info/RECORD files, which allows importlib.metadata to correctly report files associated with a package. A corresponding test case has been added to tests/venv_site_packages_libs/ to verify this behavior. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
importlib.metadata.files()returnsNonefor packages installed viarules_python's wheel rules. This happens because theRECORDfile in the.dist-infodirectory is explicitly excluded from thedataattribute of the generatedpy_librarytargets.To fix this, remove
**/*.dist-info/RECORDfrom the_data_excludelist inwhl_library_targets.bzl. This ensures that theRECORDfile is preserved in the runfiles and available at runtime, enablingimportlib.metadata.files()to correctly list the files in the package.#3024