Skip to content

ci: update RBE toolchain version from ubuntu2204 to ubuntu2404#3778

Merged
meteorcloudy merged 3 commits into
mainfrom
meteorcloudy-patch-2
May 19, 2026
Merged

ci: update RBE toolchain version from ubuntu2204 to ubuntu2404#3778
meteorcloudy merged 3 commits into
mainfrom
meteorcloudy-patch-2

Conversation

@meteorcloudy
Copy link
Copy Markdown
Contributor

@meteorcloudy meteorcloudy commented May 15, 2026

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the RBE toolchain version from Ubuntu 22.04 to 24.04 in python/private/internal_dev_deps.bzl. Feedback indicates that the WORKSPACE file should also be updated to maintain consistency and prevent CI failures for WORKSPACE-based builds.

Comment thread python/private/internal_dev_deps.bzl
@meteorcloudy
Copy link
Copy Markdown
Contributor Author

Hmm, actually ubuntu2204 should still be supported. There might be some infra breakages caused by https://github.com/bazelbuild/continuous-integration/pull/2617/changes

/cc @coeuvre

@coeuvre
Copy link
Copy Markdown

coeuvre commented May 18, 2026

I have regenerated toolchain for ubuntu2204.

@meteorcloudy
Copy link
Copy Markdown
Contributor Author

Upgrading rules_cc fixed the RBE build

@meteorcloudy meteorcloudy enabled auto-merge May 19, 2026 12:27
@aignas aignas changed the title Update RBE toolchain version from ubuntu2204 to ubuntu2404 ci: update RBE toolchain version from ubuntu2204 to ubuntu2404 May 19, 2026
@meteorcloudy meteorcloudy added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit 32527de May 19, 2026
8 checks passed
@meteorcloudy meteorcloudy deleted the meteorcloudy-patch-2 branch May 19, 2026 14:24
kevinpark1217 pushed a commit to kevinpark1217/rules_python that referenced this pull request May 19, 2026
kevinpark1217 pushed a commit to kevinpark1217/rules_python that referenced this pull request May 19, 2026
kevinpark1217 pushed a commit to kevinpark1217/rules_python that referenced this pull request May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants