fix(system_python): Remove printing of not always present attribute#3781
Open
limdor wants to merge 1 commit into
Open
fix(system_python): Remove printing of not always present attribute#3781limdor wants to merge 1 commit into
limdor wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes an AttributeError on Debian 10 by removing a print_verbose call for sys._base_executable in the Python bootstrap template. Feedback was provided to correct a typo in the CHANGELOG.md file, changing the Debian 10 codename from "Booster" to "Buster".
| * (pypi) Fix `importlib.metadata.files` by ensuring `RECORD` is included in | ||
| installed wheel targets, except when built from sdist | ||
| ([#3024](https://github.com/bazel-contrib/rules_python/issues/3024)). | ||
| * (system_python) Fix AttributeError exception on Debian 10 Booster |
Contributor
There was a problem hiding this comment.
There is a typo in the Debian release name. It should be Buster instead of Booster, to match the Debian 10 codename and the description in the pull request.
Suggested change
| * (system_python) Fix AttributeError exception on Debian 10 Booster | |
| * (system_python) Fix AttributeError exception on Debian 10 Buster |
This attribute is not part of the Python public API and in Debian 10 Buster (OpenJDK 11, gcc 8.3.0) it seems to not be defined. This reverts one of the debug logging statements added in bazel-contrib#3667 Fixes bazel-contrib#3774
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attribute is not part of the Python public API and in Debian 10 Buster (OpenJDK 11, gcc 8.3.0) it seems to not be defined.
This reverts one of the debug logging statements added in #3667
Fixes #3774