fix: strip full Java platform suffix from gem version when querying RubyGems API#373
Merged
Merged
Conversation
…ubyGems API
The previous `gem.version.replace("-java", "")` only handles the bare
`-java` platform; for gems whose platform is `universal-java` (e.g.
`ffi-yajl-2.6.0-universal-java`) it leaves a `-universal` tail and queries
a non-existent RubyGems version, hard-failing the repo rule.
Replace the naive strip with a helper that covers all four real-world Java
platform shapes: `java`, `java-N`, `universal-java`, `universal-java-N`.
p0deje
approved these changes
May 28, 2026
Member
|
Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous
gem.version.replace("-java", "")only handles the bare-javaplatform; for gems whose platform isuniversal-java(e.g.ffi-yajl-2.6.0-universal-java) it leaves a-universaltail and queries a non-existent RubyGems version, hard-failing the repo rule.Replace the naive strip with a helper that covers all four real-world Java platform shapes:
java,java-N,universal-java,universal-java-N.