Dep tracking filtering #1241
Merged
Dep tracking filtering #1241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liucijus
added
the
dep-tracking
simuons
reviewed
Mar 8, 2021
scala/scala_toolchain.bzl
Outdated
|
|
||
| all_strict_deps_patterns = ctx.attr.dependency_tracking_strict_deps_patterns | ||
|
|
||
| strict_deps_include_patterns = [ |
Collaborator
There was a problem hiding this comment.
Maybe extract a function to partition patterns into include/exclude lists
simuons
reviewed
Mar 8, 2021
| return ctx.toolchains["@io_bazel_rules_scala//scala:toolchain_type"].unused_dependency_checker_mode | ||
|
|
||
| def _is_target_included(target, includes, excludes): | ||
| if len([exclude for exclude in excludes if target.startswith(exclude)]) > 0: |
Collaborator
There was a problem hiding this comment.
Maybe instead of building list and checking length you could use loop with an if? For example
for exclude in excludes:
if target.startswith(exclude):
return False
Or maybe if any([target.startswith(exclude) for exclude in excludes]) but I guess you would building new list each time however it might not be an issue.
Collaborator
Author
There was a problem hiding this comment.
I'm leaning towards simple loop
simuons
approved these changes
Mar 8, 2021
Collaborator
simuons
left a comment
simuons
left a comment
There was a problem hiding this comment.
LGTM. Just couple minor comments/suggestions.
ittaiz
approved these changes
Mar 10, 2021
wisechengyi
pushed a commit
to twitter-forks/rules_scala
that referenced
this pull request
Mar 11, 2021
* Add target prefix filters support for strict/unused deps * Add dependecy tracking filtering docs * Remove todo comment * Extract deps pattern partition function, optimize pattern macthing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1240