-
-
Notifications
You must be signed in to change notification settings - Fork 289
chore: Add support for Scala 3.3.7 LTS #1777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the one failed tests seems to be flaky and related to test infra. Seems like I don't have access to restart it, can you try to trigger new CI run (e.g. by pushing empty commit)
To be clear, there aren't any flaky tests in our suite. This was purely a transient infrastructure failure: ERROR: /private/var/tmp/_bazel_buildkite/778e17b638fcf3f7bb99ffb5d7806875/external/bazel_tools/tools/build_defs/repo/http.bzl:136:45: An error occurred during the fetch of repository 'rules_buf+':
--
| Traceback (most recent call last):
| File "/private/var/tmp/_bazel_buildkite/778e17b638fcf3f7bb99ffb5d7806875/external/bazel_tools/tools/build_defs/repo/http.bzl", line 136, column 45, in _http_archive_impl
| download_info = ctx.download_and_extract(
| Error in download_and_extract: java.io.IOException: Error downloading [https://github.com/bufbuild/rules_buf/archive/abbbfce7c3fccf1d4b87afa28140d9ce53f80057.zip] to /private/var/tmp/_bazel_buildkite/778e17b638fcf3f7bb99ffb5d7806875/external/rules_buf+/temp15976215966924422746/abbbfce7c3fccf1d4b87afa28140d9ce53f80057.zip: Connect timed out
ERROR: /private/var/tmp/_bazel_buildkite/778e17b638fcf3f7bb99ffb5d7806875/external/bazel_tools/tools/launcher/BUILD:11:10: @@bazel_tools//tools/launcher:launcher depends on @@bazel_tools//src/tools/launcher:launcher in repository @@bazel_tools which failed to fetch. no such package '@@rules_buf+//buf': java.io.IOException: Error downloading [https://github.com/bufbuild/rules_buf/archive/abbbfce7c3fccf1d4b87afa28140d9ce53f80057.zip] to /private/var/tmp/_bazel_buildkite/778e17b638fcf3f7bb99ffb5d7806875/external/rules_buf+/temp15976215966924422746/abbbfce7c3fccf1d4b87afa28140d9ce53f80057.zip: Connect timed out
--
| ERROR: Analysis of target '//:print-single-test-tag-values' failed; build aborted: Analysis failedI'll review now and push an empty commit to get things going. |
CI failed due to a transient infrastructure failure while downloading the `rules_buf` archive: - bazel-contrib#1777 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
So the "BCR 8.x on macOS" runs failed due to another infrastructure error: ERROR: /private/var/tmp/_bazel_buildkite/6293f5784b037152acb5b62ceb1735ab/external/bazel_tools/tools/build_defs/repo/http.bzl:155:45: An error occurred during the fetch of repository 'rules_shell+':
--
| Traceback (most recent call last):
| File "/private/var/tmp/_bazel_buildkite/6293f5784b037152acb5b62ceb1735ab/external/bazel_tools/tools/build_defs/repo/http.bzl", line 155, column 45, in _http_archive_impl
| download_info = ctx.download_and_extract(
| Error in download_and_extract: java.io.IOException: Error downloading [https://github.com/bazelbuild/rules_shell/releases/download/v0.3.0/rules_shell-v0.3.0.tar.gz] to /private/var/tmp/_bazel_buildkite/6293f5784b037152acb5b62ceb1735ab/external/rules_shell+/temp16700079221615259198/rules_shell-v0.3.0.tar.gz: Connect timed outBut it clearly passed all the other BCR permutations, and passed in the previous build. GitHub seems to be having a rough time of it lately. Merging. |
|
Thanks! |
Updates the following Bazel dependency versions: - `.bazelversion`: 7.6.1 => 7.6.2 - Go: 1.25.1 => 1.25.3 - `bazel_skylib`: 1.8.1 => 1.8.2 - `golang.org/x/tools`: 0.37.0 => 0.38.0 - `protobuf`: v32.1 => v33.0 - Still missing protocolbuffers/protobuf#19679, so we keep patching. - `rules_cc`: 0.2.8 => 0.2.10 - `rules_go`: 0.57.0 => bazel-contrib/rules_go@74199c92 - This is a temporary workaround for bazel-contrib/rules_go#4480. - `rules_java`: 8.15.2 => 8.16.1 - Updates all legacy `WORKSPACE` files to invoke `bazel_features_deps` _before_ `rules_java_dependencies`, required since `rules_java` 8.16.0. - Adds `bazel_features` 1.37.0 to `rules_scala_dependencies` from `latest_deps.bzl` as an explicit dependency to enable the dependency setup macro reordering. - `rules_python`: 1.6.1 => 1.6.3 Updates the following Maven artifact versions, with `scripts/create_repository.py` having generated the changes to `third_party/repositories/scala_*.bzl`: - `com.google.api.grpc:proto-google-common-protos`: 2.61.1 => 2.62.0 - `com.google.guava:guava`: 33.4.8-jre => 33.5.0-jre - `com.google.protobuf:protobuf-java`: 4.32.1 => 4.33.0 - `com.thesamet.scalapb:scalapb-runtime_*`: 1.0.0-alpha.2 => 1.0.0-alpha.3 - `io.grpc:grpc-api`: 1.75.0 => 1.76.0 - `org.scala-lang.modules:scala-parser-combinators_*`: 1.1.2 => 2.4.0 - Adds logic to `scripts/create_repository.py` to keep the Scala 2.11 version of `scala-parser-combinators` at version 1.1.2 - `org.scala-sbt:compiler-interface`: 1.10.1 => 1.11.0 - `org.scala-sbt:util-interface`: 1.11.6 => 1.11.7 - `org.scalameta:scalafmt-*`: 3.9.9 => 3.10.1 - Updates `version` in all the `**.scalafmt*.conf` files to match. - `org.typelevel:kind-projector_*`: 0.13.3 => 0.13.4 --- This is in preparation for releasing v7.1.3, which will also contain the Scala 3.3.7 update from bazel-contrib#1777.
Updates the following Bazel dependency versions: - `.bazelversion`: 7.6.1 => 7.6.2 - Go: 1.25.1 => 1.25.3 - `bazel_skylib`: 1.8.1 => 1.8.2 - `golang.org/x/tools`: 0.37.0 => 0.38.0 - `protobuf`: v32.1 => v33.0 - Still missing protocolbuffers/protobuf#19679, so we keep patching. - `rules_cc`: 0.2.8 => 0.2.10 - `rules_go`: 0.57.0 => bazel-contrib/rules_go@74199c92 - This is a temporary workaround for bazel-contrib/rules_go#4480. - `rules_java`: 8.15.2 => 8.16.1 - Updates all legacy `WORKSPACE` files to invoke `bazel_features_deps` _before_ `rules_java_dependencies`, required since `rules_java` 8.16.0. - Adds `bazel_features` 1.37.0 to `rules_scala_dependencies` from `latest_deps.bzl` as an explicit dependency to enable the dependency setup macro reordering. - `rules_python`: 1.6.1 => 1.6.3 Updates the following Maven artifact versions, with `scripts/create_repository.py` having generated the changes to `third_party/repositories/scala_*.bzl`: - `com.google.api.grpc:proto-google-common-protos`: 2.61.1 => 2.62.0 - `com.google.guava:guava`: 33.4.8-jre => 33.5.0-jre - `com.google.protobuf:protobuf-java`: 4.32.1 => 4.33.0 - `com.thesamet.scalapb:scalapb-runtime_*`: 1.0.0-alpha.2 => 1.0.0-alpha.3 - `io.grpc:grpc-api`: 1.75.0 => 1.76.0 - `org.scala-lang.modules:scala-parser-combinators_*`: 1.1.2 => 2.4.0 - Adds logic to `scripts/create_repository.py` to keep the Scala 2.11 version of `scala-parser-combinators` at version 1.1.2 - `org.scala-sbt:compiler-interface`: 1.10.1 => 1.11.0 - `org.scala-sbt:util-interface`: 1.11.6 => 1.11.7 - `org.scalameta:scalafmt-*`: 3.9.9 => 3.10.1 - Updates `version` in all the `**.scalafmt*.conf` files to match. - `org.typelevel:kind-projector_*`: 0.13.3 => 0.13.4 --- This is in preparation for releasing v7.1.3, which will also contain the Scala 3.3.7 update from #1777.
Description
Update to latest release LTS version https://github.com/scala/scala3/releases/tag/3.3.7
Motivation
Part of our release flow
CC @WojciechMazur