Improve test efficiency, reduce lock file size #1784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes unnecessary `scala_deps.scala()` tags from the
`dt_patches/test_dt_patches{,_user_srcjar}` and
`test/compiler_sources_integrity` modules. Removes `bazel shutdown`
commands to speed up several tests, notably
`dt_patches/dt_patch_test.sh` and `test/shell/test_examples.sh`.
---
These changes are broken out from a larger change to commit
`MODULE.bazel.lock` files. That upcoming change will explain the
rationale for doing so, but these changes stand alone as incremental
improvements in their own right.
Removing the `scala_deps.scala()` tags prevents the `scala_deps`
extension from creating repos for the default Scala toolchain. These
particular tests define their own Scala toolchains, so the tests still
pass without the extra default Scala toolchain footprint. This has the
additional benefit of making the resulting `MODULE.bazel.lock` files
much smaller.
The test speedups from removing `bazel shutdown` were opportunistic
improvements during the course of the `MODULE.bazel.lock` investigation.
|
@simuons @WojciechMazur Once this pull request and #1783 lands, I'll be able to send a pull request for Here's a preview of what it will look like, using a commit stacked on top of the changes from this pull request and #1783: |
WojciechMazur
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes unnecessary
scala_deps.scala()tags from thedt_patches/test_dt_patches{,_user_srcjar}andtest/compiler_sources_integritymodules. Removesbazel shutdowncommands to speed up several tests, notablydt_patches/dt_patch_test.shandtest/shell/test_examples.sh.Motivation
These changes are broken out from a larger change to commit
MODULE.bazel.lockfiles. That upcoming change will explain the rationale for doing so, but these changes stand alone as incremental improvements in their own right.Removing the
scala_deps.scala()tags prevents thescala_depsextension from creating repos for the default Scala toolchain. These particular tests define their own Scala toolchains, so the tests still pass without the extra default Scala toolchain footprint. This has the additional benefit of making the resultingMODULE.bazel.lockfiles much smaller.The test speedups from removing
bazel shutdownwere opportunistic improvements during the course of theMODULE.bazel.lockinvestigation.