Support JMH for scala 2.12 #295 #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This looks great. When CI is green, will merge. Thank you very much! This was a blocker on 2.12 for us. |
Contributor
|
closes #295 |
Contributor
Author
|
What's about scala2_12 branch? How to merge it there? |
johnynek
pushed a commit
that referenced
this pull request
Apr 1, 2018
johnynek
added a commit
that referenced
this pull request
Apr 2, 2018
Cherry pick and merge #465 into scala 2.12 branch
ianoc-stripe
pushed a commit
to ianoc-stripe/rules_scala
that referenced
this pull request
Jun 12, 2018
* Upgrade versions of JMH 1.17.4 -> 1.20, asm 5.0.4 -> 6.1.1 * Add reflection-based generator for JMH (make it default)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use reflection-based generator (RFGeneratorSource) instead of ASM-based, it does support Java8 byte-code.
Also version of JMH is upgraded.