Skip to content

Reuse @com_google_protobuf//:protoc when generating scala from proto #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2019
Merged

Reuse @com_google_protobuf//:protoc when generating scala from proto #708

merged 3 commits into from
Mar 4, 2019

Conversation

@simuons
Copy link
Collaborator

@simuons simuons commented Mar 4, 2019

Remove protoc-jar which brings own versions of protoc

@simuons simuons requested a review from johnynek as a code owner March 4, 2019 07:45
@simuons simuons mentioned this pull request Mar 4, 2019
Closed
@simuons
Copy link
Collaborator Author

simuons commented Mar 4, 2019

Resolves #690

johnynek
johnynek reviewed Mar 4, 2019
View reviewed changes
Copy link
Contributor

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. Take or leave it.

So if I read correctly this is somewhat orthogonal to @ianoc-stripe’s PR since he can take this same approach (maybe does already?) in his PR?

src/scala/scripts/PBGenerateRequest.scala Outdated
import java.nio.file.{Files, Path, Paths}

class PBGenerateRequest(val jarOutput: String, val scalaPBOutput: Path, val scalaPBArgs: List[String])
class PBGenerateRequest(val jarOutput: String, val scalaPBOutput: Path, val scalaPBArgs: List[String], val protoc: String)
Copy link
Contributor

@johnynek johnynek Mar 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should protoc be a Path?

Copy link
Collaborator Author

@simuons simuons Mar 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to Path

@simuons
Copy link
Collaborator Author

simuons commented Mar 4, 2019

@johnynek yes this is orthogonal to @ianoc-stripe's changes. These changes are not in his PR but he can take them and incorporate to his PR. Your call, I have no objections.

@simuons
Copy link
Collaborator Author

simuons commented Mar 4, 2019 •
edited
Loading

One side effect is that messages like

protoc-jar: protoc version: 3.6.0, detected platform: osx-x86_64 (mac os x/x86_64)
protoc-jar: embedded: bin/3.6.0/protoc-3.6.0-osx-x86_64.exe
protoc-jar: executing: [/var/folders/6w/7lqypyx94r161fg4g11fmkqh0000gn/T/protocjar6233866923743660333/bin/protoc.exe, --plugin=protoc-gen-scala=/var/folders/6w/7lqypyx94r161fg4g11fmkqh0000gn/T/protocbridge2956289356396485960, --scala_out=/var/folders/6w/7lqypyx94r161fg4g11fmkqh0000gn/T/bazelscalapb4934520006979171911, --proto_path=external/com_google_protobuf, -Igoogle/protobuf/wrappers.proto=bazel-out/darwin-fastbuild/genfiles/external/com_google_protobuf/google/protobuf/wrappers.proto, -Itest/proto/test_external_dep.proto=test/proto/test_external_dep.proto, bazel-out/darwin-fastbuild/genfiles/external/com_google_protobuf/google/protobuf/wrappers.proto, test/proto/test_external_dep.proto]

are not printed anymore (those used to come from protoc-jar). Useful for debugging but not essential.

@johnynek
Copy link
Contributor

johnynek commented Mar 4, 2019

cc @ianoc-stripe this seems like a good thing to copy in the aspect version.

@johnynek johnynek merged commit 88ad68b into bazel-contrib:master Mar 4, 2019
@simuons simuons deleted the reuse-protoc branch October 23, 2020 08:22
gergelyfabian pushed a commit to gergelyfabian/rules_scala that referenced this pull request May 31, 2022
@marchof @Godin
Remove unused constants (bazel-contrib#708)
c8b8c9d 
This was forgotten in bazel-contrib#652.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@johnynek johnynek johnynek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@simuons @johnynek @googlebot