Skip to content

Add compatibility test for v1.2.0 #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
+17 −9
Closed

Add compatibility test for v1.2.0 #881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41cbd39
Add compatibility test for v1.1.0
chenrui333 Nov 22, 2019
95bd52b
Add compatibility test for bazel v1.2.0
chenrui333 Nov 22, 2019
e80bc50
Remove compatibility test for bazel v1.0.0 and v1.1.0
chenrui333 Nov 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,22 +48,22 @@ jobs:
<<: *linux
env: TEST_SCRIPT=test_lint
# Test
- <<: *linux
env: TEST_SCRIPT=test_rules_scala BAZEL_VERSION=1.0.0
- <<: *linux
env: TEST_SCRIPT=test_rules_scala
- <<: *linux
env: TEST_SCRIPT=test_reproducibility BAZEL_VERSION=1.0.0
- <<: *linux
env: TEST_SCRIPT=test_reproducibility
- <<: *osx
env: TEST_SCRIPT=test_rules_scala
- <<: *osx
env: TEST_SCRIPT=test_rules_scala BAZEL_VERSION=1.0.0
env: TEST_SCRIPT=test_reproducibility
- <<: *linux
env: TEST_SCRIPT=test_rules_scala BAZEL_VERSION=1.2.0
- <<: *linux
env: TEST_SCRIPT=test_reproducibility BAZEL_VERSION=1.2.0
- <<: *osx
env: TEST_SCRIPT=test_reproducibility BAZEL_VERSION=1.0.0
env: TEST_SCRIPT=test_rules_scala BAZEL_VERSION=1.2.0
- <<: *osx
env: TEST_SCRIPT=test_reproducibility
env: TEST_SCRIPT=test_reproducibility BAZEL_VERSION=1.2.0

before_install:
- |
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ This project defines core build rules for [Scala](https://www.scala-lang.org/) t
## Getting started

1. [Install Bazel](https://docs.bazel.build/versions/master/install.html), see the [compatibility table](#bazel-compatible-versions).
2. Add the following to your `WORKSPACE` file and update the `githash` if needed:
2. Add the following to your `WORKSPACE` file and update the `githash` if needed:

```python
rules_scala_version="69d3c5b5d9b51537231746e93b4383384c9ebcf4" # update this as needed
Expand Down Expand Up @@ -108,7 +108,7 @@ for an example workspace using another scala version.

| bazel | rules_scala gitsha |
|--------|--------------------|
| 1.0.0 | HEAD |
| 1.2.0 | HEAD |
| 0.28.0 | HEAD |
| 0.23.x | ca655e5a330cbf1d66ce1d9baa63522752ec6011 | |
| 0.22.x | f3113fb6e9e35cb8f441d2305542026d98afc0a2 |
Expand Down
8 changes: 8 additions & 0 deletions tools/bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,14 @@ case "$bazel_version" in
darwin_sha='fdab79e3a89e979b63487fd268761aac17a6ca4c8a41830743978c46d2160ff9'
linux_sha='f8490463360fff5992b5a5af93f930ff984588765f9ccf3e7dd03db5145fbf0f'
;;
'1.1.0')
darwin_sha='1a552f4ce194860fbbd50eeb319f81788ddf50a849e92378eec72231cc64ef65'
linux_sha='14301099c87568db302d59a5d3585f5eb8a6250ac2c6bb0367c56e623ff6e65f'
;;
'1.2.0')
darwin_sha='14da01972d16f43db1962dfc5246bef33e2d619dddeb1ce133ec0c8c18627610'
linux_sha='181b57714200fa5579e12fe3ab4e6f3fd7f6827dff4ec16ff5190302130216af'
;;
*)
echo "The requested Bazel version '$bazel_version' is not supported"
exit 1
Expand Down