Merged
Conversation
This function is marked with [[nodiscard]], which generates a warning because the result is unused. Issue: Compiler warning when compiling crosstool/libtool.cc: [-Wunused-result] bazelbuild#574 bazelbuild#574
jpc-sf
requested review from
aaronsky,
adincebic,
brentleyjones,
keith,
luispadron and
mattrobmattrob
as code owners
keith
approved these changes
Apr 21, 2026
Member
keith
left a comment
keith
left a comment
There was a problem hiding this comment.
thanks! just to note you must be on an internal SDK or something, it doesn't seem like this is marked [[nodiscard]] yet.
Contributor
Author
|
my pleasure. yeah, it looks like some STL implementations add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is marked with [[nodiscard]], which generates a warning because the result is unused.
Issue: Compiler warning when compiling crosstool/libtool.cc: [-Wunused-result] #574 #574