Skip to content

[1/3] Bump grpc java to 1.31.1 too#12255

Closed
dmivankov wants to merge 1 commit intobazelbuild:masterfrom
dmivankov:grpc_java_1_31_1_part_1
Closed

[1/3] Bump grpc java to 1.31.1 too#12255
dmivankov wants to merge 1 commit intobazelbuild:masterfrom
dmivankov:grpc_java_1_31_1_part_1

Conversation

@dmivankov
Copy link
Copy Markdown
Contributor

Part 1: switch third_party/grpc to 1.31.1 but keep 1.26.0 jars around
Composed PR: #12241

Between 1.26.0 and 1.31.1 grpc-java had changes including

  • bugfixes
  • netty 4.1.42.Final -> 4.1.48.Final (we're already on 4.1.48.Final)
  • guava 28.1-android -> 29.0-android (we're already on 29.0-android)
  • google auth 0.18.0 -> 0.20.0 (we're still on 0.17.1)
  • protobuf 3.11.0 -> 3.12.0 (not a runtime dependency)

Transitively there's also dependency updates

  • google-http-client 1.30.1 -> 1.33.0 (we're still on 1.22.0)
  • jackson-core .. -> 2.10.0 (we're at 2.8.6)
    and likely more

Quick look over changelogs doesn't reveal big breakages, so hopefully
this the update is compatible with other bootstrap jars

Part 1: switch third_party/grpc to 1.31.1 but keep 1.26.0 jars around
Composed PR: bazelbuild#12241

Between 1.26.0 and 1.31.1 grpc-java had changes including
- bugfixes
- netty 4.1.42.Final -> 4.1.48.Final (we're already on 4.1.48.Final)
- guava 28.1-android -> 29.0-android (we're already on 29.0-android)
- google auth 0.18.0 -> 0.20.0 (we're still on 0.17.1)
- protobuf 3.11.0 -> 3.12.0 (not a runtime dependency)

Transitively there's also dependency updates
- google-http-client 1.30.1 -> 1.33.0 (we're still on 1.22.0)
- jackson-core .. -> 2.10.0 (we're at 2.8.6)
and likely more

Quick look over changelogs doesn't reveal big breakages, so hopefully
this the update is compatible with other bootstrap jars
Copy link
Copy Markdown
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bazel-io bazel-io closed this in d4cd4e7 Oct 13, 2020
coeuvre pushed a commit to coeuvre/bazel that referenced this pull request Oct 22, 2020
Part 1: switch third_party/grpc to 1.31.1 but keep 1.26.0 jars around
Composed PR: bazelbuild#12241

Between 1.26.0 and 1.31.1 grpc-java had changes including
- bugfixes
- netty 4.1.42.Final -> 4.1.48.Final (we're already on 4.1.48.Final)
- guava 28.1-android -> 29.0-android (we're already on 29.0-android)
- google auth 0.18.0 -> 0.20.0 (we're still on 0.17.1)
- protobuf 3.11.0 -> 3.12.0 (not a runtime dependency)

Transitively there's also dependency updates
- google-http-client 1.30.1 -> 1.33.0 (we're still on 1.22.0)
- jackson-core .. -> 2.10.0 (we're at 2.8.6)
and likely more

Quick look over changelogs doesn't reveal big breakages, so hopefully
this the update is compatible with other bootstrap jars

Closes bazelbuild#12255
coeuvre pushed a commit to coeuvre/bazel that referenced this pull request Oct 22, 2020
Part 1: switch third_party/grpc to 1.31.1 but keep 1.26.0 jars around
Composed PR: bazelbuild#12241

Between 1.26.0 and 1.31.1 grpc-java had changes including
- bugfixes
- netty 4.1.42.Final -> 4.1.48.Final (we're already on 4.1.48.Final)
- guava 28.1-android -> 29.0-android (we're already on 29.0-android)
- google auth 0.18.0 -> 0.20.0 (we're still on 0.17.1)
- protobuf 3.11.0 -> 3.12.0 (not a runtime dependency)

Transitively there's also dependency updates
- google-http-client 1.30.1 -> 1.33.0 (we're still on 1.22.0)
- jackson-core .. -> 2.10.0 (we're at 2.8.6)
and likely more

Quick look over changelogs doesn't reveal big breakages, so hopefully
this the update is compatible with other bootstrap jars

Closes bazelbuild#12255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants