Propagate tags for the AndroidBinary actions#13093
Closed
nkoroste wants to merge 5 commits intobazelbuild:masterfrom
Closed
Propagate tags for the AndroidBinary actions#13093nkoroste wants to merge 5 commits intobazelbuild:masterfrom
nkoroste wants to merge 5 commits intobazelbuild:masterfrom
Conversation
Tags are not propagated from targets to actions for Android rules. bazelbuild#8830 This PR adds basic propagation of tags from the android_binary target it's actions. Testing with aquery with the Android repo: ./bazelw aquery 'mnemonic(RClassGenerator, //apps/foo)' ./bazelw aquery 'mnemonic(JavaDeployJar, //apps/foo)' ./bazelw aquery 'mnemonic(ApkBuilder, //apps/foo)'
ahumesky
reviewed
Feb 24, 2021
Contributor
ahumesky
left a comment
ahumesky
left a comment
There was a problem hiding this comment.
Thanks! Just a few comments
src/main/java/com/google/devtools/build/lib/rules/android/AndroidBinary.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/rules/android/AndroidBinary.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/rules/android/AndroidBinary.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/rules/android/ApkActionsBuilder.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Cleaned everything up, PTAL |
Contributor
|
Thanks, I'll start the import on this on Monday |
Contributor
|
I've imported the change internally, just waiting for internal code review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tags are not propagated from targets to actions for Android rules. #8830
This PR adds basic propagation of tags from the android_binary target it's actions.
Testing with aquery with the Android repo: