Upload dangling symlinks found in the outputs of local actions.#16352
Closed
tjgq wants to merge 1 commit intobazelbuild:masterfrom
Closed
Upload dangling symlinks found in the outputs of local actions.#16352tjgq wants to merge 1 commit intobazelbuild:masterfrom
tjgq wants to merge 1 commit intobazelbuild:masterfrom
Conversation
Since we don't know whether a dangling symlink is supposed to point to a file or a directory, we always report it as a symlink to a file. The distinction only matters in V2 of the protocol, with V2.1 reporting them uniformly, so it doesn't seem to be worth the effort to match up the input and output types. Dangling symlinks to absolute paths are unconditionally uploaded. A followup PR will gate their upload on the presence of the respective server capability (SymlinkAbsolutePathStrategy.ALLOW). Progress towards bazelbuild#16289.
coeuvre
approved these changes
Sep 29, 2022
aiuto
pushed a commit
to aiuto/bazel
that referenced
this pull request
Oct 12, 2022
Since we don't know whether a dangling symlink is supposed to point to a file or a directory, we always report it as a symlink to a file. The distinction only matters in V2 of the protocol, with V2.1 reporting them uniformly, so it doesn't seem to be worth the effort to match up the input and output types. Dangling symlinks to absolute paths are unconditionally uploaded. A followup PR will gate their upload on the presence of the respective server capability (SymlinkAbsolutePathStrategy.ALLOW). The change is behind a new --incompatible_remote_dangling_symlinks flag, which will be introduced in the flipped state. See bazelbuild#16353. Progress towards bazelbuild#16289. Closes bazelbuild#16352. PiperOrigin-RevId: 477735370 Change-Id: I6210d152529e4603a49377a9e72e8e116ced6b85
ShreeM01
added
the
team-Remote-Exec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we don't know whether a dangling symlink is supposed to point to a file or a directory, we always report it as a symlink to a file. The distinction only matters in V2 of the protocol, with V2.1 reporting them uniformly, so it doesn't seem to be worth the effort to match up the input and output types.
Dangling symlinks to absolute paths are unconditionally uploaded. A followup PR will gate their upload on the presence of the respective server capability (SymlinkAbsolutePathStrategy.ALLOW).
The change is behind a new
--incompatible_remote_dangling_symlinksflag, which will be introduced in the flipped state. See #16353.Progress towards #16289.