[7.4.0] Fix ml path for Windows clang-cl cc toolchain#23406
Merged
Conversation
Assembly files are not valid inputs for `clang-cl.exe`; the MSVC `ml64.exe` must be used instead. Fixes bazelbuild#23128. Closes bazelbuild#23337. PiperOrigin-RevId: 666406544 Change-Id: Ia7a5fc4702f08a5754145ca286c079d1a4f0e204
iancha1992
added
team-Rules-CPP
iancha1992
requested review from
meteorcloudy
and removed request for
meteorcloudy
meteorcloudy
requested changes
Aug 26, 2024
meteorcloudy
approved these changes
Aug 28, 2024
github-actions
Bot
removed
the
awaiting-review
Member
|
@michaelsiegrist Should we revert this change given more users are broken by this? |
Contributor
|
Not yet; I think this fixes an actual bug. I can locally verify that That said, if this is causing more problems than it solves and the argument-passing stuff can't be resolved, I can look at backing this out and solving the problem we're experiencing on my end. |
meteorcloudy
added a commit
to meteorcloudy/bazel
that referenced
this pull request
Nov 5, 2024
…uild#23406)" This reverts commit cb1bc28.
meteorcloudy
added a commit
that referenced
this pull request
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assembly files are not valid inputs for
clang-cl.exe; the MSVCml64.exemust be used instead.Fixes #23128.
Closes #23337.
PiperOrigin-RevId: 666406544
Change-Id: Ia7a5fc4702f08a5754145ca286c079d1a4f0e204
Commit e5a083d