Support %bazel_workspace% interpolation in --repo_env
#25608
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
fmeum
force-pushed
the
repo-env-interpolation
branch
from
9e68934 to
b923c3e
Compare
Member
Do we actually know any of such use case? |
Collaborator
Author
No, but it doesn't seem unrealistic for some other tool to treat |
Member
|
%FOO% is actually how you reference an env var on Windows, maybe this could be a problem? |
iancha1992
added
the
team-ExternalDeps
fmeum
force-pushed
the
repo-env-interpolation
branch
2 times, most recently
from
59bb1fb to
57695d1
Compare
Member
|
Do we support this for |
Collaborator
Author
|
We could, but I don't think that's a step in the right direction. If you have in-repo tools, IMO you should wrap them in targets and depend on those in your rules rather than non-hermetically adding them to PATH. I still haven't figured out the remaining CI issue. It seems to be related to MSYS/Windows path styles. |
fmeum
requested review from
a team,
brandjon,
comius,
fweikert,
gregestren,
lberki,
pzembrod,
tetromino and
trybka
as code owners
fmeum
force-pushed
the
repo-env-interpolation
branch
from
ca82607 to
ba0d24e
Compare
fmeum
removed request for
comius,
fweikert,
gregestren,
lberki,
pzembrod and
trybka
fmeum
force-pushed
the
repo-env-interpolation
branch
from
ba0d24e to
a43adf8
Compare
fmeum
force-pushed
the
repo-env-interpolation
branch
2 times, most recently
from
4433b58 to
42e0618
Compare
`%bazel_workspace%` is used instead of the more conventional `%workspace%` to avoid changing the behavior of existing `--repo_env` usages in which `%workspace%` may already have a meaning. RELNOTES: In environment variable values set via `--repo_env`, the substring `%bazel_workspace%` is now replaced with the absolute path of the current Bazel workspace. This can, for example, be used to make tools checked into the repository available on the `PATH` for repository rules.
fmeum
force-pushed
the
repo-env-interpolation
branch
from
b118151 to
057ff26
Compare
Collaborator
Author
|
@meteorcloudy Tests are passing now |
meteorcloudy
approved these changes
Nov 4, 2025
meteorcloudy
added
awaiting-PR-merge
Collaborator
Author
|
@bazel-io fork 9.0.0 |
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Nov 6, 2025
`%bazel_workspace%` is used instead of the more conventional `%workspace%` to avoid changing the behavior of existing `--repo_env` usages in which `%workspace%` may already have a meaning. RELNOTES: In environment variable values set via `--repo_env`, the substring `%bazel_workspace%` is now replaced with the absolute path of the current Bazel workspace. This can, for example, be used to make tools checked into the repository available on the `PATH` for repository rules. Closes bazelbuild#25608. PiperOrigin-RevId: 828862407 Change-Id: I644fbb25d80c5353e522c7184d7c57b2ac8bf04f
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2025
…7562) `%bazel_workspace%` is used instead of the more conventional `%workspace%` to avoid changing the behavior of existing `--repo_env` usages in which `%workspace%` may already have a meaning. RELNOTES: In environment variable values set via `--repo_env`, the substring `%bazel_workspace%` is now replaced with the absolute path of the current Bazel workspace. This can, for example, be used to make tools checked into the repository available on the `PATH` for repository rules. Closes #25608. PiperOrigin-RevId: 828862407 Change-Id: I644fbb25d80c5353e522c7184d7c57b2ac8bf04f Commit 6dc16b9 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%bazel_workspace%is used instead of the more conventional%workspace%to avoid changing the behavior of existing--repo_envusages in which%workspace%may already have a meaning.RELNOTES: In environment variable values set via
--repo_env, the substring%bazel_workspace%is now replaced with the absolute path of the current Bazel workspace. This can, for example, be used to make tools checked into the repository available on thePATHfor repository rules.