[8.2.0] Clear AsyncTaskCaches after shutdown#25619
Merged
coeuvre merged 1 commit intobazelbuild:release-8.2.0from Mar 26, 2025
Merged
[8.2.0] Clear AsyncTaskCaches after shutdown#25619coeuvre merged 1 commit intobazelbuild:release-8.2.0from
AsyncTaskCaches after shutdown#25619coeuvre merged 1 commit intobazelbuild:release-8.2.0from
Conversation
`RemoteActionInputPrefetcher` is retained through `RemoteActionFileSystem` and in turn retains all finished `AsyncTaskCache` tasks, which are only relevant intra-build and can thus be dropped after shutdown. This saves ~1% of retained heap on the Bazel frontend example. Closes bazelbuild#25579. PiperOrigin-RevId: 738084614 Change-Id: Ia6f5e9a20f026a861f649090e6f72f8b2152443f
bazel-io
added
team-Remote-Exec
tjgq
approved these changes
Mar 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
coeuvre
approved these changes
Mar 26, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 26, 2025
`RemoteActionInputPrefetcher` is retained through `RemoteActionFileSystem` and in turn retains all finished `AsyncTaskCache` tasks, which are only relevant intra-build and can thus be dropped after shutdown. This saves ~1% of retained heap on the Bazel frontend example. Closes #25579. PiperOrigin-RevId: 738084614 Change-Id: Ia6f5e9a20f026a861f649090e6f72f8b2152443f Commit 0ce2f95 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Merged
via the queue into
bazelbuild:release-8.2.0
with commit Mar 26, 2025
f93a55d
46 checks passed
github-actions
bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemoteActionInputPrefetcheris retained throughRemoteActionFileSystemand in turn retains all finishedAsyncTaskCachetasks, which are only relevant intra-build and can thus be dropped after shutdown. This saves ~1% of retained heap on the Bazel frontend example.Closes #25579.
PiperOrigin-RevId: 738084614
Change-Id: Ia6f5e9a20f026a861f649090e6f72f8b2152443f
Commit 0ce2f95