[8.3.0] Add profiler span for sending the Execute request
#25977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are seeing profiles in which there is a large gap between the start of the `execute remotely` span and the the start of the `queue` span reported by the remote executor. The current theory is that there is contention on the channel with async tasks spawned by `--remote_cache_async` which this span could help pin down. Closes bazelbuild#25947. PiperOrigin-RevId: 753068760 Change-Id: I2b004152ab695530d02d160b8c7b446fcc89e60f
bazel-io
added
team-Remote-Exec
coeuvre
approved these changes
May 15, 2025
Merged
via the queue into
bazelbuild:release-8.3.0
with commit May 15, 2025
ffddc93
46 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing profiles in which there is a large gap between the start of the
execute remotelyspan and the the start of thequeuespan reported by the remote executor. The current theory is that there is contention on the channel with async tasks spawned by--remote_cache_asyncwhich this span could help pin down.Closes #25947.
PiperOrigin-RevId: 753068760
Change-Id: I2b004152ab695530d02d160b8c7b446fcc89e60f
Commit 659d5f9