Avoid repeated calls to FileSystems.getNativeFileSystem in MockToolsConfig#28048
Open
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Open
Avoid repeated calls to FileSystems.getNativeFileSystem in MockToolsConfig#28048fmeum wants to merge 1 commit intobazelbuild:masterfrom
FileSystems.getNativeFileSystem in MockToolsConfig#28048fmeum wants to merge 1 commit intobazelbuild:masterfrom
Conversation
…lsConfig` This makes it easier to step through `OS.getCurrent()` usages when debugging and should be marginally more efficient.
github-actions
bot
added
the
awaiting-review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors MockToolsConfig to avoid repeated calls to FileSystems.getNativeFileSystem(). A private final field is introduced to cache the native file system instance, which is a good practice for both efficiency and debuggability. The changes are correct and well-implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to step through
OS.getCurrent()usages when debugging and should be marginally more efficient.