Skip to content

Update and minimize the JDK for Windows arm64 builds#28632

Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum:fix-windows-arm
Closed

Update and minimize the JDK for Windows arm64 builds#28632
fmeum wants to merge 1 commit intobazelbuild:masterfrom
fmeum:fix-windows-arm

Conversation

@fmeum
Copy link
Collaborator

@fmeum fmeum commented Feb 11, 2026

Fixes #28520

@fmeum fmeum force-pushed the fix-windows-arm branch 4 times, most recently from f77f1f1 to da862ed Compare February 11, 2026 14:17
@fmeum fmeum changed the title Minimize the JDK for Windows arm64 builds Update and ,inimize the JDK for Windows arm64 builds Feb 11, 2026
@fmeum fmeum changed the title Update and ,inimize the JDK for Windows arm64 builds Update and minimize the JDK for Windows arm64 builds Feb 11, 2026
This is possible now that we cross-jlink.
@fmeum fmeum requested a review from meteorcloudy February 11, 2026 14:29
@fmeum fmeum marked this pull request as ready for review February 11, 2026 14:29
@fmeum
Copy link
Collaborator Author

fmeum commented Feb 11, 2026

@bazel-io fork 9.1.0

@fmeum
Copy link
Collaborator Author

fmeum commented Feb 11, 2026

@bazel-io fork 9.0.1

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the JDK for Windows arm64 builds to address a bug with virtual threads, and enables JDK minimization for this platform. The changes, which involve updating the JDK dependency and modifying the minimization script to support cross-minimization, are logical and well-implemented. I have one suggestion to correct a typo in a URL within a comment to improve future maintainability.

@fmeum fmeum requested a review from Wyverald February 11, 2026 15:22
@iancha1992 iancha1992 added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Feb 11, 2026
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Feb 18, 2026
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 19, 2026
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Feb 19, 2026
Fixes bazelbuild#28520

Closes bazelbuild#28632.

PiperOrigin-RevId: 872274729
Change-Id: Ib29a4b4c03582fc8cbf647d9cd3ddf7eb1547daa
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Feb 19, 2026
Fixes bazelbuild#28520

Closes bazelbuild#28632.

PiperOrigin-RevId: 872274729
Change-Id: Ib29a4b4c03582fc8cbf647d9cd3ddf7eb1547daa
github-merge-queue bot pushed a commit that referenced this pull request Feb 23, 2026
…#28714)

Fixes #28520

Closes #28632.

PiperOrigin-RevId: 872274729
Change-Id: Ib29a4b4c03582fc8cbf647d9cd3ddf7eb1547daa

Commit
799c54f

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
github-merge-queue bot pushed a commit that referenced this pull request Feb 23, 2026
…#28715)

Fixes #28520

Closes #28632.

PiperOrigin-RevId: 872274729
Change-Id: Ib29a4b4c03582fc8cbf647d9cd3ddf7eb1547daa

Commit
799c54f

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bazel on windows arm64 hangs in repo downloads

3 participants