Skip to content

[9.0.1] Only use workspace facts for validation with --lockfile_mode=error (h…#28767

Merged
iancha1992 merged 1 commit intobazelbuild:release-9.0.1from
iancha1992:cp28719
Feb 24, 2026
Merged

[9.0.1] Only use workspace facts for validation with --lockfile_mode=error (h…#28767
iancha1992 merged 1 commit intobazelbuild:release-9.0.1from
iancha1992:cp28719

Conversation

@iancha1992
Copy link
Member

…ttps://github.com//pull/28718)

When validating the facts in a lockfile with --lockfile_mode=error, only use the user-visible lockfile, not the hidden output root lockfile Fixes #28717

No

  • I have added tests for the new use cases (if any).
  • I have updated the documentation (if applicable).

RELNOTES: Fix --lockfile_mode=error validation when rolling back changes to module extension facts

Closes #28718.

PiperOrigin-RevId: 874282163
Change-Id: I1479dcd6b756dc9d8b01183c4bfe15dd8700aeba

Description

Motivation

Build API Changes

No

Checklist

  • I have added tests for the new use cases (if any).
  • I have updated the documentation (if applicable).

Release Notes

RELNOTES: None

Commit ce5f8ba

…azelbuild#28718)

When validating the facts in a lockfile with `--lockfile_mode=error`, only use the user-visible lockfile, not the hidden output root lockfile
Fixes bazelbuild#28717

No

- [X] I have added tests for the new use cases (if any).
- [ ] I have updated the documentation (if applicable).

RELNOTES: Fix --lockfile_mode=error validation when rolling back changes to module extension facts

Closes bazelbuild#28718.

PiperOrigin-RevId: 874282163
Change-Id: I1479dcd6b756dc9d8b01183c4bfe15dd8700aeba
@iancha1992 iancha1992 added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Feb 24, 2026
@iancha1992 iancha1992 marked this pull request as ready for review February 24, 2026 01:08
@iancha1992 iancha1992 requested a review from a team as a code owner February 24, 2026 01:08
@iancha1992 iancha1992 enabled auto-merge February 24, 2026 01:09
@iancha1992 iancha1992 added this pull request to the merge queue Feb 24, 2026
Merged via the queue into bazelbuild:release-9.0.1 with commit 100442e Feb 24, 2026
47 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants