Fix overflow in network metrics counters#28856
Closed
keith wants to merge 1 commit intobazelbuild:masterfrom
Closed
Fix overflow in network metrics counters#28856keith wants to merge 1 commit intobazelbuild:masterfrom
keith wants to merge 1 commit intobazelbuild:masterfrom
Conversation
This was broken in d34d638. On macOS subsequent network updates can reset the counters, which resulted in overflow. Now if the new value is lower we just replace it with that. This should be harmless for the Linux use case where this should never be the case. Fixes bazelbuild#28813
github-actions
bot
added
team-Performance
Member
Author
|
cc @coeuvre |
Member
Author
|
For example here's what the values can look like with a reset on macOS: |
tjgq
approved these changes
Mar 3, 2026
tjgq
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Mar 3, 2026
This was broken in d34d638. On macOS subsequent network updates can reset the counters, which resulted in overflow. Now if the new value is lower we just replace it with that. This should be harmless for the Linux use case where this should never be the case. Fixes bazelbuild#28813 Closes bazelbuild#28856. PiperOrigin-RevId: 877956215 Change-Id: Ic7667494c19fe854edcc7bc8df4b845214484086
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Mar 3, 2026
This was broken in d34d638. On macOS subsequent network updates can reset the counters, which resulted in overflow. Now if the new value is lower we just replace it with that. This should be harmless for the Linux use case where this should never be the case. Fixes bazelbuild#28813 Closes bazelbuild#28856. PiperOrigin-RevId: 877956215 Change-Id: Ic7667494c19fe854edcc7bc8df4b845214484086
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
This was broken in d34d638. On macOS subsequent network updates can reset the counters, which resulted in overflow. Now if the new value is lower we just replace it with that. This should be harmless for the Linux use case where this should never be the case. Fixes #28813 Closes #28856. PiperOrigin-RevId: 877956215 Change-Id: Ic7667494c19fe854edcc7bc8df4b845214484086 Commit 6ce9065 Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
This was broken in d34d638. On macOS subsequent network updates can reset the counters, which resulted in overflow. Now if the new value is lower we just replace it with that. This should be harmless for the Linux use case where this should never be the case. Fixes #28813 Closes #28856. PiperOrigin-RevId: 877956215 Change-Id: Ic7667494c19fe854edcc7bc8df4b845214484086 Commit 6ce9065 Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was broken in d34d638. On macOS
subsequent network updates can reset the counters, which resulted in
overflow. Now if the new value is lower we just replace it with that.
This should be harmless for the Linux use case where this should never
be the case.
Fixes #28813