[9.1.0] Materialize important outputs from remote external repos (https://git…

[iancha1992]

…hub.com//pull/28308)

Important outputs and runfiles from external repos that are remote repo contents cache hits got stuck at various levels of the materialization pipeline for being source artifacts. This is fixed by consolidating the skip logic in a RemoteOutputChecker static helper.

Closes #28308.

PiperOrigin-RevId: 881618604
Change-Id: Ifaae8e39b0bcab3803653ca82bcf00d26c487316

Description

Motivation

Build API Changes

No

Checklist

• I have added tests for the new use cases (if any).
• I have updated the documentation (if applicable).

Release Notes

RELNOTES: None

Commit 16613f1

[iancha1992]

@Wyverald @tjgq The merge keeps getting cancelled so I am not able to merge this. Could you please take a look?

[Wyverald]

that's weird indeed. I definitely don't think this PR specifically is to blame... although the failure is almost consistent at this point:

(06:57:38) ERROR: /Users/buildkite/builds/bk-macos-arm64-7zy8/bazel/bazel-bazel-github-presubmit/scripts/BUILD:9:8: Executing genrule //scripts:bash_completion failed: (Exit 1): bash failed: error executing Genrule command (from genrule rule target //scripts:bash_completion)
--
(cd /Users/buildkite/Library/Caches/bazel/_bazel_buildkite/68d94bab791abb705f6382b93049c21e/sandbox/darwin-sandbox/9731/execroot/_main && \
exec env - \
PATH=/bin:/usr/bin:/usr/local/bin \
/bin/bash -c 'source external/bazel_tools/tools/genrule/genrule-setup.sh;
TMPDIR=$(mktemp -d)
trap '\''rm -rf $TMPDIR'\'' EXIT
bazel-out/default_host_platform-opt-exec/bin/src/bazel --batch --output_user_root=$TMPDIR help completion bash > bazel-out/darwin_arm64-fastbuild/bin/scripts/bazel-complete.bash
')
# Configuration: 21635da9a90826e301194e74d72feac79f1a382759d7542acf587d7168d311b2
# Execution platform: //:default_host_platform
 
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
WARNING: Invoking Bazel in batch mode since it is not invoked from within a workspace (below a directory having a MODULE.bazel file).
Corrupt installation: file '/var/folders/4f/b9w38j2s03z2mm13c3z7z5_m0000gp/T/tmp.uYuGRSV0rX/install/A-server.jar' is missing or modified (this is expected if the installation is too old).
Removing previous installation at '/var/folders/4f/b9w38j2s03z2mm13c3z7z5_m0000gp/T/tmp.uYuGRSV0rX/install/' because it is corrupted or matches a different version
Extracting Bazel installation...
Error: Unable to access jarfile /var/folders/4f/b9w38j2s03z2mm13c3z7z5_m0000gp/T/tmp.uYuGRSV0rX/install/A-server.jar