Skip to content

Also send --remote_cache_headers to an HTTP cache#28978

Closed
chrisjakins wants to merge 4 commits intobazelbuild:masterfrom
chrisjakins:issue28960
Closed

Also send --remote_cache_headers to an HTTP cache#28978
chrisjakins wants to merge 4 commits intobazelbuild:masterfrom
chrisjakins:issue28960

Conversation

@chrisjakins
Copy link
Copy Markdown
Contributor

@chrisjakins chrisjakins commented Mar 13, 2026

Issue 28960

Description

  • Merge all HTTP header categories when building the remote cache request

Motivation

  • If a user wants to use different headers with remote_cache_header and remote_exec_header, it is not possible

Build API Changes

No

Checklist

  • I have added tests for the new use cases (if any).
  • I have updated the documentation (if applicable).

Release Notes

RELNOTES: None

@chrisjakins chrisjakins requested a review from a team as a code owner March 13, 2026 02:44
@github-actions github-actions bot added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Mar 13, 2026
@bigelephant29 bigelephant29 requested a review from tjgq March 17, 2026 14:40
return ImmutableList.<Entry<String, String>>builder()
.addAll(options.remoteHeaders)
.addAll(options.remoteCacheHeaders)
.addAll(options.remoteExecHeaders)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to contradict the flag documentation, which says --remote_exec_headers are only sent to remote execution?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thank you. I've updated the code and tests.

@chrisjakins chrisjakins requested a review from tjgq March 20, 2026 17:27
@tjgq tjgq changed the title Update HTTP Headers to additionally collect extra cache/execution headers Also send --remote_cache_headers to an HTTP cache Mar 25, 2026
@tjgq tjgq added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Mar 25, 2026
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Remote-Exec Issues and PRs for the Execution (Remote) team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants