[9.1.0] Prevent template_ctx.run from using map_directory outputs as inputs.

[iancha1992]

This has the following implications:

• Internal actions (generated by template_ctx.run()) cannot take both subtrees and their parent tree artifacts as inputs, which might be problematic for remote execution as artifacts are "streamed" (potentially causing the same files from the subtree to be added twice).
• Ensures encapsulation of the action graph generated by map_directory(). For example, internal actions generated within map_directory(implementation) themselves depending on the output directories of the same map_directory() breaks encapsulation.

PiperOrigin-RevId: 884538235
Change-Id: If6c8f4990dea353460de9bdde5f5abca61f8b5a8

Description

Motivation

Build API Changes

No

Checklist

• I have added tests for the new use cases (if any).
• I have updated the documentation (if applicable).

Release Notes

RELNOTES: None

Commit e46bed7

[iancha1992]

@tjgq @fmeum Could you please take a look at the CI errors?

[zhengwei143]

I think we will need to cherrypick the following commits as well, notably (2) is a prior commit that this change is dependent on

1. 195502f: Remove type restrictions for map_directory() arg additional_params
2. 0c7a1bc: Add template_ctx.declare_subdirectory() API that allows template actions to declare output subdirectories within a parent output directory.

[tjgq]

Let's not cherry-pick this, then. (I was under the impression that declare_subdirectory was already in 9.x; if it's not, then let's wait until someone requests a backport.)

[iancha1992]

@tjgq @zhengwei143 This one was actually requested by @fmeum. I've created #29097, which contains all three commits. Let's see if it passes.