[9.1.0] Use FileArtifactValue#setContentsProxy for remote repo contents cache (https://github.com/bazelbuild/bazel/pull/28654)#29016
Merged
iancha1992 merged 1 commit intobazelbuild:release-9.1.0from Mar 17, 2026
Conversation
…he (bazelbuild#28654) Even though expiration times don't matter in Bazel (they aren't honored), supporting the contents proxy optimization avoids Skyframe invalidation when external repo files are materialized later. Along the way ensure that the persistent action cache always recreates remote metadata via `FileArtifactValue.createForRemoteFileWithMaterializationData`. Before this change, such metadata would roundtrip into a `RemoteFileArtifactValue` (without the content proxy optimization) if `expirationTime` is set to `null`. Closes bazelbuild#28654. PiperOrigin-RevId: 884796123 Change-Id: Ib399aff3864f5fbbef230b64a7a5ef619bf854d0
bazel-io
added
team-Performance
tjgq
approved these changes
Mar 17, 2026
Merged
via the queue into
bazelbuild:release-9.1.0
with commit Mar 17, 2026
329f3bf
46 checks passed
github-actions
bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though expiration times don't matter in Bazel (they aren't honored), supporting the contents proxy optimization avoids Skyframe invalidation when external repo files are materialized later.
Along the way ensure that the persistent action cache always recreates remote metadata via
FileArtifactValue.createForRemoteFileWithMaterializationData. Before this change, such metadata would roundtrip into aRemoteFileArtifactValue(without the content proxy optimization) ifexpirationTimeis set tonull.Closes #28654.
PiperOrigin-RevId: 884796123
Change-Id: Ib399aff3864f5fbbef230b64a7a5ef619bf854d0
Commit 257a224