Replace hardcoded -g0 with toolchain features#29048
Open
keith wants to merge 1 commit intobazelbuild:masterfrom
Open
Replace hardcoded -g0 with toolchain features#29048keith wants to merge 1 commit intobazelbuild:masterfrom
keith wants to merge 1 commit intobazelbuild:masterfrom
Conversation
Must be paired with a rules_cc version bump that includes bazelbuild/rules_cc#649 Fixes bazelbuild#13308 Fixes bazelbuild#24545
github-actions
bot
added
the
awaiting-review
Member
Author
|
cc @gregestren |
Contributor
|
Nice simplification!
What's the right merge sequence? Given that presubmit CI isn't failing, Bazel's core CI doesn't cover this? |
Member
Author
|
yea ideally we would merge the rules_cc change, create a release, and then i would pull that release bump into this change. i think the risk of merging them out of sync is actually that internal google toolchains are expecting this and don't get it. because the default public toolchains default to having this for |
Contributor
|
Okay, we can put this into the internal merge queue and see what happens? |
gregestren
approved these changes
Mar 27, 2026
gregestren
added
awaiting-PR-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Must be paired with a rules_cc version bump that includes bazelbuild/rules_cc#649
Fixes #13308
Fixes #24545