packages: allow idempotent exports_files visibility#29220
Open
abishekgiri wants to merge 1 commit intobazelbuild:masterfrom
Open
packages: allow idempotent exports_files visibility#29220abishekgiri wants to merge 1 commit intobazelbuild:masterfrom
abishekgiri wants to merge 1 commit intobazelbuild:masterfrom
Conversation
Contributor
Author
|
Reopened this change from the neutral branch name exports-files-visibility-fix. The targeted test command is in the PR body; local execution on this machine is still blocked by the unaccepted Xcode license. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change makes repeated exports_files() declarations with the same logical visibility idempotent, even when the visibility is represented by distinct RuleVisibility instances.
What changed
Root cause
exports_files() used != to compare visibilities. That works for singleton public and private visibilities, but it rejects repeated custom visibilities because each parse can allocate a fresh RuleVisibility object even when the declared labels are identical.
Impact
Packages can safely repeat the same custom visibility in exports_files() without tripping a false "declared twice" error, while genuinely conflicting visibilities still fail.
Testing
Tried locally:
Current local blocker: