Support for toolchains aspects wildcard "*"#29415
Open
darkrift wants to merge 3 commits intobazelbuild:masterfrom
Open
Support for toolchains aspects wildcard "*"#29415darkrift wants to merge 3 commits intobazelbuild:masterfrom
darkrift wants to merge 3 commits intobazelbuild:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
If a build_setting is marked as repeatable = True or allow_multiple = True, then in the command line events we should emit a separate Option message for each instance of the corresponding flag. The simplest way to do so is to store the set of repeatable/allow_multiple flag names, and pass it through the options provider. Otherwise, we end up with nonsense like `--//my:cflags=[-DX,-DY,-DZ]` in the emitted events, which cannot be pasted back into the terminal. PiperOrigin-RevId: 906478500 Change-Id: I6a8ed27682417b23ac22e6800e5e695fe841ed6e
darkrift
force-pushed
the
toolchains_aspects_wildcard
branch
4 times, most recently
from
3ed25f0 to
90644f0
Compare
darkrift
force-pushed
the
toolchains_aspects_wildcard
branch
from
90644f0 to
49d6b49
Compare
github-actions
Bot
added
team-Configurability
Author
|
@susinmotion @fmeum if you could review. It would also be nice to backport to 9 afterward and possibly 8 if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds support for "*" in toolchains_aspects the same way as attr_aspects does.
Disclaimer, all of it was produced by codex AI.
Fixes #29258
Motivation
This allows for generic aspects to not know in advance all the toolchains it would have to interact with when those toolchains adds various generic provides
Build API Changes
This changes allows for toolchain_types to be iterated on where applicable as a sequence such as
for toolchain_type in ctx.rule.toolchains.toolchain_types():Checklist
Release Notes
RELNOTES: None