Fix SIGTERM handling in collect_coverage.sh for test timeouts#29565
Open
olbapmar wants to merge 1 commit into
Open
Fix SIGTERM handling in collect_coverage.sh for test timeouts#29565olbapmar wants to merge 1 commit into
olbapmar wants to merge 1 commit into
Conversation
Bash does not run trap handlers while a foreground process is executing. When Bazel sends SIGTERM on test timeout, the coverage wrapper dies immediately, meaning that the test process has no opportunity to shut down gracefully or clean up resources. Background the test process and use wait so that the SIGTERM trap fires. The handler waits for the child to finish its own signal handling before exiting.
github-actions
Bot
added
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bash does not run trap handlers while a foreground process is executing.
When Bazel sends SIGTERM on test timeout, the coverage wrapper dies immediately, meaning that the test process has no opportunity to shut down gracefully or clean up resources.
Background the test process and use wait so that the SIGTERM trap fires. The handler waits for the child to finish its own signal handling before exiting.
Motivation
This allows test authors to register SIGTERM handlers for graceful shutdown and resource cleanup during coverage runs.
Build API Changes
No
Checklist
Release Notes
RELNOTES: None