Fix ArtifactFactory.getPathFromSourceExecPath for external repos#29657
Open
keith wants to merge 1 commit into
Open
Fix ArtifactFactory.getPathFromSourceExecPath for external repos#29657keith wants to merge 1 commit into
keith wants to merge 1 commit into
Conversation
This function is only called for include scanning, which isn't used widely externally today. Previously if a source file was from an external repo it would not be correctly found by this function, which assumed all source files are relative to the workspace.
github-actions
Bot
added
team-Performance
fmeum
approved these changes
May 27, 2026
github-actions
Bot
added
the
community-reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is only called for include scanning, which isn't used
widely externally today. Previously if a source file was from an
external repo it would not be correctly found by this function, which
assumed all source files are relative to the workspace.