[9.1.1] Cache CAS interactions at lower layer to fix lost input handling#29673
Closed
iancha1992 wants to merge 2 commits into
Closed
[9.1.1] Cache CAS interactions at lower layer to fix lost input handling#29673iancha1992 wants to merge 2 commits into
iancha1992 wants to merge 2 commits into
Conversation
PiperOrigin-RevId: 919057784 Change-Id: Ie8d5f84654b5305add288e86768996fd0e648080
…elbuild#29551) The error handling for uploads in `UploadTask` depends on the exec path of the uploaded file, which wasn't part of the `casUploadCache` cache key. Fix this by moving deduplication logic for CAS uploads and `FindMissing` calls into `RemoteCacheClient`. Avoids spurious Bazel failures caused by lost inputs that can't be recovered from via build or action rewinding due to `CacheNotFoundException` being marked with exec paths of inputs to concurrent actions (see the new test case). No - [x] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). RELNOTES: Fixed an issue that caused Bazel to fail on a lost input even with build or action rewinding enabled. Closes bazelbuild#29551. PiperOrigin-RevId: 922775351 Change-Id: Ia22580325c3bc92b56d202e5c24d3630fc8c27a0
iancha1992
added
the
awaiting-review
github-actions
Bot
added
team-Core
This was referenced May 28, 2026
Member
Author
iancha1992
force-pushed
the
cp5572634408f_new
branch
from
394ce3c to
a1f54c7
Compare
Member
|
@fmeum how critical is this? This is now the last thing blocking 9.1.1. If you think we must include it, could you send a cherry-pick PR? Otherwise, we should just start rc1 to get 9.1.1 out to address the crash bugs that people are seeing. |
Collaborator
|
It fixes a feature released in 9.1.0, so it's less critical than a crash bug fix, but still meaningful. Sorry, I didn't monitor the milestone this time and didn't realize it was this close. Sent #29677, which cherry-picks two BUILD file refactorings. |
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ps://github.com//pull/29551)
The error handling for uploads in
UploadTaskdepends on the exec path of the uploaded file, which wasn't part of thecasUploadCachecache key. Fix this by moving deduplication logic for CAS uploads andFindMissingcalls intoRemoteCacheClient.Avoids spurious Bazel failures caused by lost inputs that can't be recovered from via build or action rewinding due to
CacheNotFoundExceptionbeing marked with exec paths of inputs to concurrent actions (see the new test case).No
RELNOTES: Fixed an issue that caused Bazel to fail on a lost input even with build or action rewinding enabled.
Closes #29551.
PiperOrigin-RevId: 922775351
Change-Id: Ia22580325c3bc92b56d202e5c24d3630fc8c27a0
Description
Motivation
Build API Changes
No
Checklist
Release Notes
RELNOTES: None
Commit 1002722 and 5572634