Closed
Conversation
hlopko
approved these changes
May 21, 2019
iirina
force-pushed
the
branch-detail-analyzer
branch
from
b05baa1 to
47e0332
Compare
iirina
force-pushed
the
branch-detail-analyzer
branch
from
47e0332 to
0dc5061
Compare
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
BranchDetailAnalyzer should have also been updated as part of bazelbuild@ff1f745 when the jacoco version in bazel was updated. Changes like this will be avoided after bazelbuild#8378 is merged, because it enables testing with the java coverage tools at head. Closes bazelbuild#8417. PiperOrigin-RevId: 249400130
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BranchDetailAnalyzer should have also been updated as part of ff1f745 when the jacoco version in bazel was updated. Also upgrade the JavaBuilder dependency.
Changes like this will be avoided after #8378 is merged, because it enables testing with the java coverage tools at head.